Merged
Conversation
a5r0n
requested review from
NightWing1998,
inishchith,
nurdtechie98 and
shivam1708
as code owners
Owner
|
@h98aaron this looks good to me 👍. Thanks for the PR. |
nurdtechie98
approved these changes
Aug 6, 2019
inishchith
reviewed
Aug 7, 2019
inishchith
reviewed
Aug 7, 2019
a5r0n
commented
Aug 7, 2019
Collaborator
|
@nurdtechie98 After the suggested changes are made, I think you can make a pass on the PR and probably merge it for good ;) @h98aaron Thanks for your work! |
CHUNK_SIZE_MB env variable. Check if the file is larger than CHUNK_SIZE_MB.
inishchith
approved these changes
Aug 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #74 ( & #77 ?)
Use resumable upload if the file is larger than 256MB