Skip to content

Conversation

@vyadh
Copy link
Contributor

@vyadh vyadh commented Oct 31, 2024

See test file added in this PR.

I had to split the build and push to ensure we were not pushing any images that had failing tests, as per the recommendation from Docker here.

@hustcer
Copy link
Contributor

hustcer commented Oct 31, 2024

Thanks, let's give it a try

@hustcer hustcer merged commit f7e1587 into nushell:nightly Oct 31, 2024
@vyadh vyadh deleted the feature/run-container-build-tests branch November 1, 2024 04:16
@vyadh
Copy link
Contributor Author

vyadh commented Nov 3, 2024

@hustcer Can you pull those images? For some reason they seem missing, despite copying the GHCR command, and I'm not sure what's wrong.

For the ones generated from my fork, I get:

❯ docker pull ghcr.io/vyadh/nushell:0.99.1-alpine
0.99.1-alpine: Pulling from vyadh/nushell
Digest: sha256:8bd374adb5910b95829eb09554ec41932a3ad0520ab2c45beba038a6cfc9fc87
Status: Image is up to date for ghcr.io/vyadh/nushell:0.99.1-alpine
ghcr.io/vyadh/nushell:0.99.1-alpine

However, for the official ones, I get:

❯ docker pull ghcr.io/nushell/nushell:0.99.1-alpine
0.99.1-alpine: Pulling from nushell/nushell
manifest unknown

Any ideas?

@hustcer
Copy link
Contributor

hustcer commented Nov 3, 2024

@vyadh Thanks for reporting this issue, it was caused by the image cleanup step, and it should work now after commit: 8bdac9e

@vyadh
Copy link
Contributor Author

vyadh commented Nov 4, 2024

Great, thanks @hustcer, that works perfectly now :)

@hustcer
Copy link
Contributor

hustcer commented Dec 23, 2024

@vyadh
Copy link
Contributor Author

vyadh commented Dec 24, 2024

Thanks for the heads up @hustcer - I see you've fixed them already. Much appreciated. I had those invalid signatures all over my code, I should have remembered that might have been here too!

@hustcer
Copy link
Contributor

hustcer commented Dec 24, 2024

@vyadh 🤣 Feel free to enhance the existing code at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants