Auto overlay set PWD Variable error

[aa1ss2]

Describe the bug

Auto overlay set PWD Variable error

How to reproduce

1. Define config

let-env config = ($env.config | upsert hooks.env_change.PWD [
        {
            condition: {|_, after|
                ($after | path join mod.nu | path exists )
            }
            code: "overlay use mod.nu;let-env overlay_path = ($after);let-env PROMPT_INDICATOR = $'(ansi purple_bold)($after | path basename)(ansi reset) > '"
        }
        {
            condition: {|before, after|
                ($before != null and $after != null and $env.overlay_path not-in $after
                    and $env.overlay_path in $before
                    and 'mod' in (overlay list))
            }
            code: "overlay hide mod --keep-env [ PWD ];let-env PROMPT_INDICATOR = ''"
        }
    ])

2. Create mod.nu file.
3. Enter workplace ,trigger overlay.
4. Exit workplace
5. Re-enter workplace ,PWD error!

Expected behavior

fixed.

Screenshots

Configuration

key	value
version	0.81.0
branch
commit_hash
build_os	windows-x86_64
build_target	x86_64-pc-windows-msvc
rust_version	rustc 1.68.2 (9eb3afe9e 2023-03-27)
rust_channel	1.68.2-x86_64-pc-windows-msvc
cargo_version	cargo 1.68.2 (6feb7c9cf 2023-03-26)
build_time	2023-06-19 22:25:44 +08:00
build_rust_channel	release
features	dataframe, default, sqlite, trash, which, zip
installed_plugins	custom-value generate, custom-value generate2, custom-value update, from eml, from ics, from ini, from vcf, gstat, inc, nu-example-1, nu-example-2, nu-example-3, query, query json, query web, query xml

Additional context

No response

[sswatson]

I'm not an expert here, but I don't think this is really a bug. I think it's an expected consequence of the behaviors of the APIs being used.

To wit, I'm pretty sure what's happening is this:

1. You enter into your workspace and activate your new overlay via the first hook.
2. You change directory out of that workspace, thus: (a) modifying $env.PWD inside your overlay, and then (b) invoking overlay hide via the second hook and removing the overlay.
3. When you re-enter the workspace, the overlay is reinstated and its $env.PWD value is effected. Per 2(a), this means that by the time you get your prompt back, you are back in the workspace's parent directory.

What I'm doing to solve this problem is adding cd $after at the end of the overlay use command. This works but is a bit unsatisfactory.