Skip to content

Capture variables on aliases#17429

Draft
ayax79 wants to merge 3 commits intonushell:mainfrom
ayax79:alias_fix
Draft

Capture variables on aliases#17429
ayax79 wants to merge 3 commits intonushell:mainfrom
ayax79:alias_fix

Conversation

@ayax79
Copy link
Contributor

@ayax79 ayax79 commented Jan 26, 2026

Release notes summary - What our users need to know

Fix for #17413
This is only a fix for the aliases

@github-actions github-actions bot added the A:parser Issues related to parsing label Jan 26, 2026
@fdncred
Copy link
Contributor

fdncred commented Jan 26, 2026

I have no idea what's going on with the CI.

@sgvictorino
Copy link
Contributor

https://www.githubstatus.com/incidents/90hj03y5tj3c

@WindSoilder WindSoilder added notes:fixes Include the release notes summary in the "Bug fixes" section notes:ready The "Release notes summary" section of this PR is ready to be included in our release notes. labels Jan 27, 2026
@WindSoilder
Copy link
Contributor

Sorry I don't really get the detail, why changes are made in eval.rs but not eval_ir.rs, it also contains a eval_call function.

@ayax79
Copy link
Contributor Author

ayax79 commented Jan 27, 2026

@WindSoilder, the work in eval.rs eval_call is simply pulling the alias_captures parser_info and setting up the caller stack. The actual evaluation does happen in eval_ir.

@ayax79 ayax79 marked this pull request as draft February 5, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A:parser Issues related to parsing notes:fixes Include the release notes summary in the "Bug fixes" section notes:ready The "Release notes summary" section of this PR is ready to be included in our release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants