Skip to content

Use correct ParseError#5431

Merged
sophiajt merged 1 commit intonushell:mainfrom
Caedan:issue-5275-wrong-error-message
May 4, 2022
Merged

Use correct ParseError#5431
sophiajt merged 1 commit intonushell:mainfrom
Caedan:issue-5275-wrong-error-message

Conversation

@Caedan
Copy link
Copy Markdown
Contributor

@Caedan Caedan commented May 3, 2022

Description

Issue: #5275

Currently, the user receives a confusing error messages reading unexpected expected def or export keyword, when it should just read expected def or export keyword. This can be fixed by using ParseError::ExpectedKeyword and removing the word "expected" in the error message.

Tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --all --all-features -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo build; cargo test --all --all-features to check that all the tests pass

@sophiajt
Copy link
Copy Markdown
Contributor

sophiajt commented May 4, 2022

thanks!

@sophiajt sophiajt merged commit 02a3430 into nushell:main May 4, 2022
@hustcer hustcer modified the milestone: v0.63.0 May 6, 2022
fennewald pushed a commit to fennewald/nushell that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants