feat: add bottom margin support for reserving terminal space#1037
Closed
brancengregory wants to merge 1 commit intonushell:mainfrom
Closed
feat: add bottom margin support for reserving terminal space#1037brancengregory wants to merge 1 commit intonushell:mainfrom
brancengregory wants to merge 1 commit intonushell:mainfrom
Conversation
- Add BottomMargin enum with Fixed and Proportional variants to reserve space at the bottom of the terminal for completion menus and hints. - The margin is 'soft' - gracefully handles small screens by reducing to 0 rather than erroring. Usage: .with_bottom_margin(BottomMargin::Fixed(5)) .with_bottom_margin(BottomMargin::Proportional(0.3)) Closes nushell#1036
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults to
BottomMargin::Fixed(0), i.e. no change in behavior, backwards compatibleCloses #1036