Skip to content

Conversation

@ysthakur
Copy link
Member

As reported by @fdncred here, #798 introduced a bug in ColumnarMenu where the selected row wasn't being highlighted correctly (more specifically, text_style and description_text_style settings weren't being used). This PR fixes the bug.

After this PR, you'll see this:

image

Configuration used:

ColumnarMenu::default()
...
.with_text_style(Style::new().fg(Color::LightGreen).on(Color::DarkGray))
.with_selected_text_style(Style::new().fg(Color::LightCyan).reverse())
.with_description_text_style(Style::new().fg(Color::Yellow))
.with_match_text_style(Style::new().underline())
.with_selected_match_text_style(Style::new().fg(Color::LightRed))

@ysthakur ysthakur changed the title fix: Restore pre-#798 ColumnarMenu highlighting behavior fix: Restore pre-798 ColumnarMenu highlighting behavior Dec 28, 2025
@fdncred fdncred merged commit b81c351 into nushell:main Dec 28, 2025
6 checks passed
@fdncred
Copy link
Contributor

fdncred commented Dec 28, 2025

Thanks

@ysthakur ysthakur deleted the fix-nu-16913 branch December 28, 2025 22:20
ysthakur added a commit to nushell/nushell that referenced this pull request Dec 28, 2025
Bump Reedline to latest main to include
nushell/reedline#991, which fixes a bug in
completion menu highlighting.

## Release notes summary - What our users need to know

N/A

## Tasks after submitting

None
@fdncred
Copy link
Contributor

fdncred commented Dec 29, 2025

Ugh, just caught this. With .with_selected_match_text_style(Style::new().fg(Color::LightRed)) in the screenshot above, the foreground aka text should be light red, not the background. Something must be reversed somewhere if i'm reading this right.

So sorry I missed this earlier.

@ysthakur
Copy link
Member Author

Not your fault at all. Tested it more now, put up a new PR: #994

@ysthakur ysthakur added A-Completions Area: Tab completion and inline hint completions bug Something isn't working labels Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Completions Area: Tab completion and inline hint completions bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants