fix: support __pairs/__ipairs for non-table type #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes the pairs and ipairs functions to properly support metamethods (__pairs and __ipairs) for non-table types. Previously, these functions only checked for metamethods on LuaTable objects, which prevented non-table types with custom metatables from implementing custom iteration behavior.
Key changes:
- Modified argument retrieval to accept any
LuaValuetype instead of requiringLuaTable - Updated metamethod lookup to use
GlobalState.TryGetMetatablewhich works with any value type - Added type validation that throws an error if the value is not a table and no metamethod is found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.