Try read LuaValue#269
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates LuaValue.TryRead<T> so that requesting T == LuaValue succeeds and returns the original LuaValue instance, enabling generic code paths where T may itself be LuaValue.
Changes:
- Add a fast-path in
LuaValue.TryRead<T>forT == LuaValuethat returnsthiswithout conversion. - Add tests covering
TryRead<LuaValue>(includingNil),Read<LuaValue>, and reference preservation forTryRead<LuaTable>.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Lua/LuaValue.cs | Adds T == LuaValue special-case in TryRead<T> to return the original value. |
| tests/Lua.Tests/LuaValueTests.cs | Adds unit tests validating the new TryRead/Read behavior and table identity behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Merged! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the original ref when calling
LuaValue.TryRead<LuaValue>. This is useful for generics where T may be LuaValue.For example, the consider the following readonly LuaTable that reads from a backing
IReadOnlyDictionary<TKey, TValue>. This works as is in all cases except when the key or value type is LuaValue itself.P.S. I intend to make a PR with some of the collection wrappers I've created like the one above.