Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Resolves CI failures from Clippy warnings (issue #27) by applying suggested simplifications and removing redundant conversions.
Changes:
- Simplified byte-slice writing/reading error mapping (
map_err(Error::IoError)) and removed redundant temporaries. - Removed redundant numeric casts before
to_be_bytes()in multiple MessagePack writer implementations. - Updated test/bench code to use more idiomatic Vec initialization and API call patterns.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
zerompk/tests/derive.rs |
Simplifies construction of recursive-node MessagePack test payload bytes. |
zerompk/src/write.rs |
Removes redundant casts and simplifies error mapping in writers. |
zerompk/src/read.rs |
Simplifies IO error mapping in IOReader::read_exact. |
zerompk/src/lib.rs |
Removes unnecessary temporary variable in from_msgpack. |
zerompk/src/impl.rs |
Simplifies ToMessagePack impls for references and &str. |
zerompk/benches/deserialize_large_array.rs |
Simplifies buffer handling for msgpacker benchmark. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Merged the PR. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #27