fix: read_exact on an uninitialized buffer results in undefined behavior#8
Merged
fix: read_exact on an uninitialized buffer results in undefined behavior#8
read_exact on an uninitialized buffer results in undefined behavior#8Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_exactcan read the buffer it is passed to it, so passing an uninitialized buffer may result in undefined behavior.Therefore, this PR will fix the issue by initializing the buffer to zero. While this will result in a very slight performance decrease, it is within acceptable limits.
This can be resolved by using
read_buf_exact, but since this API is currently only available nightly, we will postpone this for now.ref: https://users.rust-lang.org/t/zerompk-extremely-fast-messagepack-serializer-for-rust/139108/9?u=nuskey8