Socket, connection handling changes #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums: Removed noresponse enum, replaced with empty and unrecognized. Socket: - Modified Disconnect sub to have more concise parameter, remove unnecessary stream disposal - Restructuring of core Query_Data subroutine. Moved or eliminated variable initialization, early sanity check for connection status, removed redundant newline in stream write, process response using .NET functions, move Enum parsing inline to subroutine, early check for null/empty response, distinct handling of good vs. bad results - Removed unused Watchdog code (essentially became null/empty case in Query subroutine) - Removed exception from Socket_Broken parameter UPS: - Stop variable update loop from calling Socket_Broken() - In multi-variable get subroutine, only recurse on VARNOTSUPPORTED or STALE errors, everything else should be thrown.
Main menu state was not being updated in a lost connection event handler.
|
I tried the debug build and can't reproduce the problem. 👏 No time to study the changes but what you said above makes very good sense. The socket stuff is handled in the socket layer and the UPS stuff does its own layer's thing and no longer goes full steam ahead except for the minor errors. Seems like a much improved/robust code structure. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to troubleshoot lost connection problem in #223. This led to some significant changes in the socket communication code.
Enums: Removed
noresponseenum, replaced withemptyandunrecognized.Socket:
UPS:
Also includes a small bugfix that makes the connection menu command buttons sync their state when the connection is lost.