Skip to content

Fix missing temp file deletion when using the mixin method #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix missing temp file deletion when using the mixin method #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/Mixins/MixinUtils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Nutgram\Laravel\Mixins;

use Illuminate\Http\File as LaravelFile;
use Illuminate\Support\Facades\Storage;
use Illuminate\Support\Str;
use Psr\Container\ContainerExceptionInterface;
Expand Down Expand Up @@ -42,13 +41,23 @@ public static function saveFileToDisk(File $file, string $path, ?string $disk =
}

//create temp file
$tmpFile = tempnam(sys_get_temp_dir(), uniqid(time(), true));
$maxMemory = 20 * 1024 * 1024;
$tmpFile = fopen(sprintf("php://temp/maxmemory:%d", $maxMemory), 'wb+');

//download file to temp file
$http = $bot->getContainer()->get(ClientInterface::class);
$http->get($bot->downloadUrl($file), array_merge(['sink' => $tmpFile], $clientOpt));
$response = $http->get($bot->downloadUrl($file), array_merge(['sink' => $tmpFile], $clientOpt));

//detach resource
$response->getBody()->detach();

//save temp file to disk
return $storage->putFileAs('/', new LaravelFile($tmpFile), $path);
$result = $storage->put($path, $tmpFile);

//close temp file
fclose($tmpFile);

//return result
return $result;
}
}