Skip to content

Conversation

@gerardsn
Copy link
Member

@gerardsn gerardsn commented May 11, 2022

reflects latest protocol update, see nuts-foundation/nuts-specification#189

If the Gossip does not result in the same XOR as its peer, the node now always makes an attempt at resolving their differences.

@gerardsn gerardsn force-pushed the network/gossip-sends-state-if-xor-unequal-and-no-new-gossiped-tx branch from b84e514 to 779156f Compare May 12, 2022 07:59
@reinkrul
Copy link
Member

Might be good to add an integration test for this? I suspect we could test this by starting one node which adds lots of TXs, then start a second node?

On the other hand, this really sounds like the "bootstrap/new node" scenario, which is probably already tested in the integration test?

@gerardsn
Copy link
Member Author

Might be good to add an integration test for this? I suspect we could test this by starting one node which adds lots of TXs, then start a second node?

On the other hand, this really sounds like the "bootstrap/new node" scenario, which is probably already tested in the integration test?

This specific change solves the case where a slow node is always behind and publishes a new transaction, but somehow the gossip didn't get through. In the old situation the peer would never be able to get its transaction out, but now it does. Added an integration test for this.

@gerardsn gerardsn requested a review from reinkrul May 12, 2022 13:37
@gerardsn gerardsn merged commit 39a19a9 into master May 13, 2022
@gerardsn gerardsn deleted the network/gossip-sends-state-if-xor-unequal-and-no-new-gossiped-tx branch May 13, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants