Skip to content

Upgrade dev-image Dockerfile to stable-slim#3886

Merged
confiks merged 1 commit intomasterfrom
upgrade-dev-image
Jul 30, 2025
Merged

Upgrade dev-image Dockerfile to stable-slim#3886
confiks merged 1 commit intomasterfrom
upgrade-dev-image

Conversation

@confiks
Copy link
Contributor

@confiks confiks commented Jul 27, 2025

Currently breaks the build on master. Buster has been EOL for LTS for a year now.

@qltysh
Copy link

qltysh bot commented Jul 27, 2025

❌ 2 blocking issues (2 total)

Tool Category Rule Count
checkov Vulnerability Ensure that a user for the container has been created 1
checkov Vulnerability Ensure that sudo isn't used 1

@confiks confiks force-pushed the upgrade-dev-image branch from f189a9a to dc58d56 Compare July 27, 2025 19:48
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably fine. We need to reconsider if this is useful though. Every time I tried to use this I had to fix something since MS DevTunnel keeps changing.

Copy link
Member

@stevenvegt stevenvegt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, buster was the stable, is now superseded by bookworm. But instead of explicitly referring to it by code-name, we use the stable tag to always use the latest one?

Hopefully a next stable update doesn't brake things. That is a risk when using a generic tag which can change from one to another.

Also, removing the contents of the /var/lib/apt/lists dir is probably stuff which got there after the update command and we don't need that anymore?

@confiks
Copy link
Contributor Author

confiks commented Jul 28, 2025

Hopefully a next stable update doesn't brake things. That is a risk when using a generic tag which can change from one to another.

I think it's better to remain on a stable version and potentially break things than to remain on an unmaintained version too long. Buster lost its LTS support a year ago, and we only noticed now that the packages were missing from the usual place.

Also, removing the contents of the /var/lib/apt/lists dir is probably stuff which got there after the update command and we don't need that anymore?

Yes, it's a pretty standard line to make the docker image a tiny bit smaller.

@confiks
Copy link
Contributor Author

confiks commented Jul 28, 2025

After fixing this we should also evaluate if this image is used at all. It might not be necessary or useful anymore, as @gerardsn already mentioned.

@confiks confiks merged commit bf62c27 into master Jul 30, 2025
6 checks passed
@confiks confiks deleted the upgrade-dev-image branch July 30, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants