refactor(dpop): eliminate variable shadowing in Parse() HTU/HTM claim validation

[Copilot]

In Parse(), the inner s variables used for HTU/HTM claim type assertions shadowed the function parameter s (raw token string), making the control flow harder to follow and risking accidental misuse.

Changes

• crypto/dpop/dpop.go: Renamed shadowing locals s → htu and htm in the HTU/HTM claim validation blocks; removed unused strings import

Before:

} else if s, ok := v.(string); !ok {   // shadows func param `s`
    ...
} else if s == "" {
    ...
} else if _, err := url.Parse(s); err != nil {

After:

} else if htu, ok := v.(string); !ok {
    ...
} else if htu == "" {
    ...
} else if _, err := url.Parse(htu); err != nil {

The return &DPoP{raw: s, ...} at the end of Parse() now unambiguously refers to the original token string parameter.

---

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

[qltysh]

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (1)

Rating	File	% Diff	Uncovered Line #s
	crypto/dpop/dpop.go	100.0%
	Total	100.0%

🚦 See full report on Qlty Cloud »

🛟 Help

• Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

• Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

• File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

  • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.