Backport: tighten v1 access token introspection to V5.4#4187
Merged
Conversation
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
The v1 introspection endpoint accepted any JWT signed by a key present on the node, allowing VP JWTs to be replayed as access tokens. This adds three validation checks to IntrospectAccessToken: - Require typ header to be "at+jwt" (set on issuance, verified on introspection) - Require non-empty iss, sub, and service claims - Verify iss claim matches the DID extracted from the kid header Backport of 41eecd4 to V5.4. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
reinkrul
force-pushed
the
fix/introspect-jwt-validation-v5.4
branch
from
2f2194c to
33bc3da
Compare
stevenvegt
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vdr/didservice/vdr/typespackages.typmust beat+jwt,iss/sub/servicemust be non-empty, and theissclaim must match the DID extracted from thekidheader.Test plan
go test ./auth/...