Make HTTPErrorHandler idempotent on committed responses#4243
Merged
Conversation
Echo's BodyDump middleware (used when http.log: metadata-and-body) calls c.Error(err) on its way out and still returns the err, so echo's server loop invokes HTTPErrorHandler a second time for the same request. The first invocation wrote the response correctly; the second logged the operation error a second time and warned "Unable to send error back to client, response already committed" — visible noise without a real problem. echo.DefaultHTTPErrorHandler short-circuits on Committed=true; ours did not. Mirror that behavior. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stevenvegt
requested review from
gerardsn,
reinkrul and
woutslakhorst
as code owners
Contributor
0 new issues
|
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
reinkrul
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
core.CreateHTTPErrorHandlershort-circuit whenctx.Response().Committedis true, mirroringecho.DefaultHTTPErrorHandler.Why
Echo's
BodyDumpmiddleware (used whenhttp.log: metadata-and-body) callsc.Error(err)on its way out and still returns the error, so Echo's server loop invokesHTTPErrorHandlera second time for the same request. The first invocation wrote the response correctly; the second logged the operation error a second time and warnedecho.DefaultHTTPErrorHandleralready short-circuits onCommitted == true. This change brings ours in line.Extracted from
This commit was originally part of #4220 but was unrelated to that PR's scope; pulled out per @reinkrul's review comment.
Test plan
core/echo_errors_test.gocovers the double-invocation case