test: bump StartServer startup poll timeout to 10s#4251
Merged
Conversation
Slow CI runners (CircleCI 1/4 CPU) occasionally exceed the 5s budget while the node initializes its heavier engines (VDR, VCR, NATS, gRPC), causing flakes in integration tests such as TestOpenID4VCIHappyFlow. Double the budget to 10s — well under any reasonable expected boot time, but enough headroom to absorb scheduler jitter on constrained runners. The polling cadence (10ms + Gosched, see test/predicates.go) still gives ~1000 polls per second. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stevenvegt
requested review from
gerardsn,
reinkrul and
woutslakhorst
as code owners
Contributor
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on 🛟 Help
|
reinkrul
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test.WaitForbudget intest/node/server.StartServerfrom 5s to 10s./statusonline.runtime.Gosched, seetest/predicates.go) is unchanged, so this only enlarges the worst-case wait — happy-path tests still finish in well under a second.Observed flake locally and on CI with
TestOpenID4VCIHappyFlow; PR #4057 didn't touch the startup path, so the 5s budget was simply too tight for slow runners.Test plan
TestOpenID4VCIHappyFlow/TestOpenID4VCIErrorResponses🤖 Generated with Claude Code