Skip to content

Moved Nuts-Network to Nuts-Node and implemented RFC004#5

Merged
reinkrul merged 1 commit into
masterfrom
add-network-v0.9
Jan 26, 2021
Merged

Moved Nuts-Network to Nuts-Node and implemented RFC004#5
reinkrul merged 1 commit into
masterfrom
add-network-v0.9

Conversation

@reinkrul
Copy link
Copy Markdown
Member

@reinkrul reinkrul commented Jan 19, 2021

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 19, 2021 •
edited
Loading

Codecov Report

Merging #5 (0ffc7bb) into master (067bf88) will increase coverage by 1.37%.
The diff coverage is 76.62%.

Impacted Files Coverage Δ
core/engine.go 83.33% <ø> (ø)
crypto/crypto.go 75.00% <ø> (ø)
crypto/engine/engine.go 79.66% <ø> (ø)
test/io/io.go 11.11% <ø> (ø)
vdr/ambassador.go 0.00% <0.00%> (ø)
vdr/vdr.go 0.00% <0.00%> (ø)
cmd/root.go 70.17% <46.15%> (+42.17%) ⬆️
network/api/v1/client.go 63.63% <63.63%> (ø)
network/dag/signing.go 69.81% <69.81%> (ø)
network/api/v1/api.go 72.72% <72.72%> (ø)
... and 22 more

woutslakhorst
woutslakhorst reviewed Jan 20, 2021
View reviewed changes
Comment thread README.rst Outdated
woutslakhorst
woutslakhorst reviewed Jan 20, 2021
View reviewed changes
Comment thread README_template.rst
woutslakhorst
woutslakhorst reviewed Jan 20, 2021
View reviewed changes
Comment thread crypto/jwx.go
Comment thread crypto/interface.go Outdated
Comment thread makefile Outdated
Comment thread network/api/api.go Outdated
Comment thread network/api/api.go Outdated
Comment thread network/engine/engine.go Outdated
Comment thread network/engine/engine.go Outdated
Comment thread network/network.go Outdated
Comment thread network/network.go Outdated
Comment thread network/rfc004/bbolt_publisher.go Outdated
@reinkrul reinkrul marked this pull request as ready for review January 22, 2021 11:48
woutslakhorst
woutslakhorst requested changes Jan 25, 2021
View reviewed changes
Comment thread network/api/v1/client.go Outdated
Comment thread network/api/v1/client.go Outdated
Comment thread core/diagnostics.go Outdated
Comment thread makefile Outdated
Comment thread network/dag/hash.go Outdated
Comment thread network/test/hashes.go Outdated
Comment thread network/api/v1/client_test.go Outdated
Comment thread network/api/v1/client_test.go Outdated
woutslakhorst
woutslakhorst requested changes Jan 25, 2021
View reviewed changes
Comment thread .gitignore Outdated
Comment thread makefile Outdated
Comment thread network/engine/engine_test.go
Comment thread network/network.go
Comment thread vdr/vdr.go
woutslakhorst
woutslakhorst approved these changes Jan 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after removal of paniccing funcs in api/client

stevenvegt
stevenvegt reviewed Jan 26, 2021
View reviewed changes
Comment thread codecov.yml
Comment thread go.mod Outdated
Comment thread network/dag/parser.go Outdated
Comment thread network/dag/test.go
Comment thread network/network.go
Comment thread network/p2p/backoff.go
Comment thread network/p2p/impl-peer.go
Comment thread network/p2p/interface.go
@reinkrul reinkrul requested a review from stevenvegt January 26, 2021 14:36
@reinkrul reinkrul merged commit 88f3e04 into master Jan 26, 2021
@reinkrul reinkrul deleted the add-network-v0.9 branch January 26, 2021 14:37
This was referenced May 26, 2026
Draft
Draft
Draft
Draft
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

@stevenvegt stevenvegt stevenvegt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reinkrul @woutslakhorst @stevenvegt