Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress): handle canceled requests #301

Merged
merged 1 commit into from Oct 22, 2019
Merged

Conversation

@ricardogobbosouza
Copy link
Member

ricardogobbosouza commented Oct 21, 2019

Resolve #211

@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #301 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #301   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        30     30           
  Branches     13     13           
===================================
  Hits         30     30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 709bd7c...2d15b55. Read the comment docs.

@pi0 pi0 changed the title fix: cancel request fix(progress): handle canceled requests Oct 22, 2019
@pi0 pi0 merged commit 5096060 into nuxt-community:dev Oct 22, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 709bd7c...2d15b55
Details
codecov/project 100% remains the same compared to 709bd7c
Details
@pi0

This comment has been minimized.

Copy link
Member

pi0 commented Oct 22, 2019

Thanks ❤️

@shlima

This comment has been minimized.

Copy link

shlima commented Oct 22, 2019

After upgrading to nuxt-axios v.5.7.0 all POST requests began to fall with an error (#302)

 await this.$axios.$post('/v1/advert')
[Log] TypeError: axios.isCancel is not a function. (In 'axios.isCancel(error)', 'axios.isCancel' is undefined)
pi0 added a commit that referenced this pull request Oct 22, 2019
@pi0

This comment has been minimized.

Copy link
Member

pi0 commented Oct 22, 2019

pi0 added a commit that referenced this pull request Oct 23, 2019
pi0 added a commit that referenced this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.