feat!: rewrite with nuxt kit and nuxt 3 support #103

maciejpedzich · 2022-02-15T07:25:38Z

No description provided.

.editorconfig

.eslintignore

.github/workflows/ci.yml

CHANGELOG.md

LICENSE

playground/feed/array.ts

renovate.json

src/module.ts

pi0 · 2022-04-01T14:28:04Z

Thanks for the pull request @maciejpedzich. I've made an overall review this is in a nice direction.

It is fine to generally have customizations in repo setup. But ideally, it should be as close as possible with module starter to keep it's consistency with the rest of (new) nuxt-community modules and I would like to hear from @manniL preferences as he is the current maintainer.
Since we are rewriting the module with Nuxt 3 in mind, ideally should also follow its design goals. Mainly, integration with nitro with an API route to allow runtime generation of sitemap vs on build generation. We can do it later but have it in mind. In the meantime, Avoid async resolve function in nuxt.config and depend on nuxt hooks for extension. (added in review comments)

docs/docus.config.ts

test/module.test.js

TheAlexLichter · 2022-04-06T14:45:30Z

Thanks for the PR! I'll have a look in the next days ☺️

maciejpedzich · 2022-04-08T12:55:43Z

Hi @pi0, thanks for the review! Sorry for taking so long, luckily I've found time to properly get down to adjusting the code accordingly with the changes you've requested. I'll let you when I'm done correcting everything.

TheAlexLichter

Left a few comments! Good job so far ☺️

TheAlexLichter · 2022-05-18T13:07:58Z

.github/workflows/ci.yml


      - name: Install dependencies
        if: steps.cache.outputs.cache-hit != 'true'
-        run: yarn


Is there a specific reason for using npm here? ☺️

TheAlexLichter · 2022-05-18T13:08:30Z

.github/workflows/ci.yml

-        run: yarn lint
+        run: npm run lint

-      - name: Test


It'd be great to release a tested module (even if not fully tested).

TheAlexLichter · 2022-05-18T13:09:43Z

docs/pages/1.index.md

+
+- Nuxt 3 ready
+- Support for RSS 2.0, Atom, and JSON formats
+- API similar to <a href="https://github.com/nuxt-community/feed-module"><code>@nuxt-communit/feed-module</code></a>, making migration over to <code>@nuxtjs/feed</code> painless


Suggested change

- API similar to <a href="https://github.com/nuxt-community/feed-module"><code>@nuxt-communit/feed-module</code></a>, making migration over to <code>@nuxtjs/feed</code> painless

- API similar to <a href="https://github.com/nuxt-community/feed-module"><code>@nuxt-community/feed-module</code></a>, making migration over to <code>@nuxtjs/feed</code> painless

TheAlexLichter · 2022-05-18T13:10:00Z

docs/pages/2.setup.md

+  <code-block label="NPM" active>
+
+```bash
+npm install --save @nuxtjs/feed


Suggested change

npm install --save @nuxtjs/feed

npm install @nuxtjs/feed

TheAlexLichter · 2022-05-18T13:11:13Z

docs/pages/3.usage.md

+```ts
+import axios from 'axios';
+
+async create(feed) {


I'd suggest printing the feed object here:

feed: { async create() { /** the rest **/ } }

TheAlexLichter · 2022-05-18T13:11:37Z

docs/pages/3.usage.md

+import axios from 'axios';
+
+async create(feed) {
+  const { data } = await axios.get<{ articles: Article[] }>(


Could we use ohmyfetch or (node) fetch for the example?

TheAlexLichter · 2022-05-18T13:12:16Z

docs/pages/3.usage.md

+
+## Dynamic module config - factory function
+
+There are cases, where the _static array_ config could turn out to be more WET and less readable/flexible. For instance, what if you needed to generate feeds based on multiple different categories, which you may also want to fetch from an external API?


'WET' might not be clear to everyone. Maybe use something like "repeatable"?

TheAlexLichter · 2022-05-18T13:14:05Z

src/lib/resolveModuleOptions.ts

+) {
+  if (typeof options === 'function') {
+    return options();
+  } else if (Array.isArray(options)) {


No else needed. Same below.

TheAlexLichter · 2022-05-18T13:14:40Z

src/module.ts

+    name: '@nuxtjs/feed',
+    configKey: 'feed'
+  },
+  setup(moduleOptions, nuxt) {


Now that SSG landed, the feed module could provide static feed generation directly too 😋

maciejpedzich · 2022-05-18T17:12:06Z

@manniL, @pi0 - I've decided to retire my custom Nuxt 3 compatible RSS feed module, and I'm afraid I won't be able to actively support the feed module as a community maintainer because I simply don't have the bandwidth to do it anymore. Feel free to reuse the code as a foundation for the official one.

TheAlexLichter · 2022-05-18T18:54:54Z

@manniL, @pi0 - I've decided to retire my custom Nuxt 3 compatible RSS feed module, and I'm afraid I won't be able to actively support the feed module as a community maintainer because I simply don't have the bandwidth to do it anymore. Feel free to reuse the code as a foundation for the official one.

@maciejpedzich Thanks a lot for being that open and for the PR! I will try to move the module to Nuxt3 based on your code in near future (and give appropriate credits) 👍

entity · 2022-05-22T16:54:06Z

@manniL, @pi0 - I've decided to retire my custom Nuxt 3 compatible RSS feed module, and I'm afraid I won't be able to actively support the feed module as a community maintainer because I simply don't have the bandwidth to do it anymore. Feel free to reuse the code as a foundation for the official one.

@maciejpedzich Thanks a lot for being that open and for the PR! I will try to move the module to Nuxt3 based on your code in near future (and give appropriate credits) 👍

Hey folks, is there any working sitemap generator these days that supports Nuxt 3 and Nuxt Content V2?

xlanex6 · 2022-05-30T14:56:48Z

Hi @manniL

Is there a roadmap, todo list to finish the job initiate by @maciejpedzich ?
I will need RSS feed on my Nuxt 3 project so... I'm ready to spend time and energy to finish what have to be done.

TheAlexLichter · 2022-05-31T11:23:59Z

Feel free to check #106. I haven't had the time to continue from here, so whoever wants to take a stab is good to go ☺️

Maciej Pędzich and others added 24 commits January 27, 2022 11:18

Initial commit

0cfcd5d

Install dependencies and add build command

02fb3a5

Add unbuild config

069ee86

Change author

3083e6f

Initial implementation (prerelease)

1ca105c

Rewrite module based on the new template

2b1c29a

Merge remote-tracking branch 'origin/master'

cee9be4

Remove unused types and utilities

0749f7e

Ignore public directory

b964429

Merge all types into a single file

1781c82

Remove redundant object resolve condition

0ea55df

Modify module options to take sources property

f50f3ad

Add module usage example to playground project

0918977

Add usage instructions

bf7e23c

Switch over to buildModules

d1e97e3

Minor edits and corrections

29f5cf2

Create documentation website

a82230d

docs: add images and icons

138f658

Rename FeedConfig* types to FeedSource*

180cd3d

Change all references to @nuxtjs/feed

14ecf0c

Merge branch 'master' of https://github.com/nuxt-modules/feed

6173658

Change all references to "@nuxtjs/feed-next"

2233cdc

Merge branch 'master' of https://github.com/maciejpedzich/feed-module

e2d9f2b

Remove double -next suffixes

78da8c8

maciejpedzich closed this Feb 15, 2022

maciejpedzich reopened this Feb 15, 2022

Maciej Pędzich added 3 commits March 26, 2022 16:23

Change all module references to nuxt-feed-module

5fd8c89

Version 1.0.1 release

b7fcf33

Remove core-js

971a35b

maciejpedzich mentioned this pull request Apr 1, 2022

Nuxt 3 Support #106

Open

pi0 changed the title ~~Merge version 3.0.0 fork into main repository~~ feat!: rewrite with nuxt kit and nuxt 3 support Apr 1, 2022

pi0 requested changes Apr 1, 2022

View reviewed changes

TheAlexLichter self-requested a review April 6, 2022 14:33

TheAlexLichter reviewed Apr 6, 2022

View reviewed changes

docs/docus.config.ts Outdated Show resolved Hide resolved

TheAlexLichter reviewed Apr 6, 2022

View reviewed changes

test/module.test.js Show resolved Hide resolved

TheAlexLichter self-assigned this Apr 6, 2022

Maciej Pędzich added 10 commits April 8, 2022 18:11

Replace references to my own and my module's name

03e3ea1

Restore CHANGELOG.md and CI workflow from v2

943aff6

Change app.vue's welcome message

79319f9

Switch from buildModules to modules

7294a23

Replace axios with ohmyfetch

ceb9cca

Deasyncify feed factory function

e3d7276

Employ useNuxt in place of binding Nuxt instance

6a99ceb

Merge branch 'master' of https://github.com/maciejpedzich/feed-module

b9b0da3

Restore ESLint ignore file

fa83c06

Add missing install command

0f1fcbc

TheAlexLichter requested changes May 18, 2022

View reviewed changes

maciejpedzich closed this May 18, 2022

nozomuikuta mentioned this pull request Jul 21, 2022

feat: nuxt 3 support #108

Closed

28 tasks

nozomuikuta mentioned this pull request Dec 14, 2022

feat: nuxt 3 support #114

Closed

21 tasks

	- API similar to <a href="https://github.com/nuxt-community/feed-module"><code>@nuxt-communit/feed-module</code></a>, making migration over to <code>@nuxtjs/feed</code> painless
	- API similar to <a href="https://github.com/nuxt-community/feed-module"><code>@nuxt-community/feed-module</code></a>, making migration over to <code>@nuxtjs/feed</code> painless


		## Dynamic module config - factory function

		There are cases, where the _static array_ config could turn out to be more WET and less readable/flexible. For instance, what if you needed to generate feeds based on multiple different categories, which you may also want to fetch from an external API?

feat!: rewrite with nuxt kit and nuxt 3 support #103

feat!: rewrite with nuxt kit and nuxt 3 support #103

Uh oh!

Conversation

maciejpedzich commented Feb 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pi0 commented Apr 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheAlexLichter commented Apr 6, 2022

Uh oh!

maciejpedzich commented Apr 8, 2022

Uh oh!

TheAlexLichter left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

maciejpedzich commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheAlexLichter commented May 18, 2022

Uh oh!

entity commented May 22, 2022

Uh oh!

xlanex6 commented May 30, 2022

Uh oh!

TheAlexLichter commented May 31, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pi0 commented Apr 1, 2022 •

edited

Loading

maciejpedzich commented May 18, 2022 •

edited

Loading