Skip to content

Conversation

@bdrtsky
Copy link
Contributor

@bdrtsky bdrtsky commented May 31, 2021

closes #337

@vercel
Copy link

vercel bot commented May 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nuxtlabs/docus/qCPXtK5pXGdh1ZYeDBXs2sMiMJRx
✅ Preview: https://docus-git-fix-releases-page-nuxtlabs.vercel.app

Copy link
Contributor

atinux commented May 31, 2021

Nicer, but TOC does not work for 0.3.0 on mobile. As well as active elements on it.

IMG_1849.MP4

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Jun 1, 2021

What exactly not working? Scrollspy? Here is it #335
Everything else work for me on mobile Sfari.

@bdrtsky
Copy link
Contributor Author

bdrtsky commented Jun 1, 2021

I see, the problem is 0.3.0 id is starting with number, which is invalid. So the only issue here is scrollspy?

@atinux
Copy link
Contributor

atinux commented Jun 1, 2021

Since scrollspy is fixed in another PR. I think this one is good :)

@atinux
Copy link
Contributor

atinux commented Jun 1, 2021

Could we have a fix regarding the titles starting with number @farnabaz or too complex?

@farnabaz
Copy link
Collaborator

farnabaz commented Jun 1, 2021

I've update the Github module. It will add prefix v if the release name does not start with an alphabetical character

image

@atinux atinux requested review from Tahul and atinux June 1, 2021 14:14
@Tahul
Copy link
Contributor

Tahul commented Jun 1, 2021

Looks good to me, excellent job guys 👏

@Tahul Tahul merged commit 135c548 into main Jun 1, 2021
@Tahul Tahul deleted the fix/releases-page branch June 3, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: releases pages design + TOC

5 participants