feat(parser): add icon support for code blocks #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for icon syntax in code block meta:
- `[filename|icon]` - filename with icon on left
- `[filename|icon|right]` - filename with icon on right
- `[|icon|position]` - icon only without filename
Changes:
- Update parseThematicBlock to extract icon and iconPosition
- Pass icon props to ProsePre component
- Add basic icon/filename header rendering in ProsePre
- Add comprehensive tests for icon parsing
Syntax example:
```python [Script|logos:python|right]
print("test")
```
Author
|
I've opened a PR in nuxt/ui that implements the UI side of this feature: nuxt/ui#5953. Also waiting for this to be merged to fully unlock the functionality. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[filename|icon|position]iconandiconPositionfrom code block syntaxProsePrecomponentSyntax
[filename|icon][filename|icon|right][|icon|position][filename]Test plan
Notes
For full icon rendering support with
@nuxt/ui, a separate PR to nuxt/ui is needed to handleiconPositioninCodeGroup.vue.