fix: capacitor config path format on windows#835
Merged
danielroe merged 6 commits intonuxt-modules:mainfrom Oct 1, 2025
Merged
fix: capacitor config path format on windows#835danielroe merged 6 commits intonuxt-modules:mainfrom
danielroe merged 6 commits intonuxt-modules:mainfrom
Conversation
✅ Deploy Preview for friendly-lamington-fb5690 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
|
i think we should be able to use jiti to do this |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 48.84% 49.59% +0.75%
==========================================
Files 12 12
Lines 735 740 +5
Branches 53 52 -1
==========================================
+ Hits 359 367 +8
+ Misses 376 373 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Importing using jiti now, but unable to fix the tests, it seems like the module mock is not picked up by jiti 🤷 |
4aad786 to
2c896bc
Compare
|
The fix works, using the patch I was able to get project working again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
This should resolve #823, this will still requires users to use the latest node LTS otherwise we need to handle importing
.tsfiles ourselves.@danielroe idk if the underlying issue is a regression (I don't use this module), I can't tell based on the related issue.