Skip to content

fix: capacitor config path format on windows#835

Merged
danielroe merged 6 commits intonuxt-modules:mainfrom
BobbieGoede:fix/windows-capacitor-config-loading
Oct 1, 2025
Merged

fix: capacitor config path format on windows#835
danielroe merged 6 commits intonuxt-modules:mainfrom
BobbieGoede:fix/windows-capacitor-config-loading

Conversation

@BobbieGoede
Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This should resolve #823, this will still requires users to use the latest node LTS otherwise we need to handle importing .ts files ourselves.

@danielroe idk if the underlying issue is a regression (I don't use this module), I can't tell based on the related issue.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 25, 2025

Deploy Preview for friendly-lamington-fb5690 ready!

Name Link
🔨 Latest commit fbcd4c4
🔍 Latest deploy log https://app.netlify.com/projects/friendly-lamington-fb5690/deploys/68dd37e09f7aa00008c9344e
😎 Deploy Preview https://deploy-preview-835--friendly-lamington-fb5690.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@danielroe
Copy link
Copy Markdown
Collaborator

i think we should be able to use jiti to do this

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.59%. Comparing base (706b5ed) to head (fbcd4c4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #835      +/-   ##
==========================================
+ Coverage   48.84%   49.59%   +0.75%     
==========================================
  Files          12       12              
  Lines         735      740       +5     
  Branches       53       52       -1     
==========================================
+ Hits          359      367       +8     
+ Misses        376      373       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BobbieGoede
Copy link
Copy Markdown
Member Author

i think we should be able to use jiti to do this

Importing using jiti now, but unable to fix the tests, it seems like the module mock is not picked up by jiti 🤷

@BobbieGoede BobbieGoede force-pushed the fix/windows-capacitor-config-loading branch from 4aad786 to 2c896bc Compare September 30, 2025 20:48
@jnettome
Copy link
Copy Markdown

jnettome commented Oct 1, 2025

The fix works, using the patch I was able to get project working again.
Thanks @BobbieGoede

Copy link
Copy Markdown
Collaborator

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

@danielroe danielroe merged commit fcc96f7 into nuxt-modules:main Oct 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nuxt module @nuxjs/ionic breaks Nuxt v4.1.1

3 participants