fix: augment NitroRouteConfig on both nitropack module paths#295
Merged
fix: augment NitroRouteConfig on both nitropack module paths#295
Conversation
Nuxt 4's @nuxt/kit unions NitroRouteConfig across both 'nitropack' and 'nitropack/types' via the v2/v3 split. Augmenting only one module path left the other re-exporting an un-augmented interface, causing the `robots` key to go missing and native keys like `ssr` to be rejected in extendRouteRules. Augment both module paths on Nuxt 4 so consumers see the complete type. Resolves #294
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #294
❓ Type of change
📚 Description
Nuxt 4's
@nuxt/kittypesNitroRouteConfigas a union across bothnitropackandnitropack/types. We were only augmenting one path, so consumers callingextendRouteRulessaw ourrobotskey disappear and native keys likessrrejected as unknown. Now augments both module paths on Nuxt 4, with a regression test covering the exact kit v4 scenario from the issue.