fix(dev): ignore link-local addresses in network urls

Author: danielroe

packages/nuxt-cli/src/dev/listen.ts

@@ -55,6 +55,22 @@ export interface Listener {
 
 const ANY_HOSTS = new Set(['', '0.0.0.0', '::'])
 
+/**
+ * External IPv4 addresses other devices can reach. IPv4 link-local addresses
+ * (169.254.0.0/16, from a macOS Thunderbolt Bridge or an unconfigured adapter)
+ * are excluded because they are unreachable from the rest of the network.
+ */
+export function getNetworkAddresses(): string[] {
+  const addresses: string[] = []
+  for (const info of Object.values(networkInterfaces()).flat()) {
+    if (!info || info.internal || info.family !== 'IPv4' || info.address.startsWith('169.254.')) {
+      continue
+    }
+    addresses.push(info.address)
+  }
+  return addresses
+}
+
 /**
  * OpenSSL 3 moved the ciphers used by older PKCS#12 exports (RC2-40, RC4, DES)
  * into the legacy provider, which Node does not load, so such keystores fail
@@ -137,11 +153,8 @@ export async function listen(handler: RequestListener, options: ListenOptions =
     }
     if (anyHost) {
       urls.push({ url: formatURL('localhost'), type: 'local' })
-      for (const info of Object.values(networkInterfaces()).flat()) {
-        if (!info || info.internal || info.family !== 'IPv4') {
-          continue
-        }
-        urls.push({ url: formatURL(info.address), type: 'network' })
+      for (const address of getNetworkAddresses()) {
+        urls.push({ url: formatURL(address), type: 'network' })
       }
     }
     else {

packages/nuxt-cli/test/unit/listen.spec.ts

@@ -0,0 +1,35 @@
+import { networkInterfaces } from 'node:os'
+
+import { describe, expect, it, vi } from 'vitest'
+
+import { getNetworkAddresses } from '../../src/dev/listen'
+
+vi.mock('node:os', () => ({
+  networkInterfaces: vi.fn(),
+  release: () => 'test',
+}))
+
+const mocked = vi.mocked(networkInterfaces)
+
+describe('getNetworkAddresses', () => {
+  it('should return external IPv4 addresses', () => {
+    mocked.mockReturnValue({
+      lo0: [{ address: '127.0.0.1', family: 'IPv4', internal: true } as any],
+      en0: [
+        { address: '192.168.1.20', family: 'IPv4', internal: false } as any,
+        { address: 'fe80::1', family: 'IPv6', internal: false } as any,
+      ],
+    })
+
+    expect(getNetworkAddresses()).toEqual(['192.168.1.20'])
+  })
+
+  it('should ignore IPv4 link-local addresses', () => {
+    mocked.mockReturnValue({
+      bridge0: [{ address: '169.254.13.37', family: 'IPv4', internal: false } as any],
+      en0: [{ address: '192.168.1.20', family: 'IPv4', internal: false } as any],
+    })
+
+    expect(getNetworkAddresses()).toEqual(['192.168.1.20'])
+  })
+})