fix: don't mistake another package.json for nuxt's own

Author: danielroe

packages/nuxt-cli/src/commands/module/search.ts

@@ -9,7 +9,7 @@ import { kebabCase, upperFirst } from 'scule'
 import { formatInfoBox } from '../../utils/formatting'
 import { logger } from '../../utils/logger'
 import { logNetworkError } from '../../utils/network'
-import { getNuxtVersion } from '../../utils/versions'
+import { DEFAULT_NUXT_VERSION, getNuxtVersion } from '../../utils/versions'
 import { cwdArgs } from '../_shared'
 import { checkNuxtCompatibility, fetchModules, MODULES_API_URL } from './_utils'
 
@@ -41,7 +41,7 @@ export default defineCommand({
     },
   },
   async setup(ctx) {
-    const nuxtVersion = await getNuxtVersion(ctx.args.cwd)
+    const nuxtVersion = await getNuxtVersion(ctx.args.cwd).catch(() => DEFAULT_NUXT_VERSION)
     return findModuleByKeywords(ctx.args._.join(' '), nuxtVersion)
   },
 })

packages/nuxt-cli/src/utils/versions.ts

@@ -5,14 +5,24 @@ import { coerce } from 'verkit'
 
 import { tryResolveNuxt } from './kit'
 
+/**
+ * Names a resolved `nuxt` dependency can legitimately have, so that a
+ * `package.json` reached through `pkg-types`' nearest-file fallback (which
+ * happens when `nuxt` cannot be resolved at all) is not mistaken for Nuxt's own.
+ */
+const NUXT_PACKAGE_NAMES = new Set(['nuxt', 'nuxt-nightly', 'nuxt3', 'nuxt-edge'])
+
+/** Assumed Nuxt version when the project declares no resolvable one. */
+export const DEFAULT_NUXT_VERSION = '3.0.0'
+
 export async function getNuxtVersion(cwd: string, cache = true) {
   const nuxtPkg = await readPackageJSON('nuxt', { url: cwd, try: true, cache }).catch(() => null)
-  if (nuxtPkg) {
-    return nuxtPkg.version!
+  if (nuxtPkg?.version && NUXT_PACKAGE_NAMES.has(nuxtPkg.name!)) {
+    return nuxtPkg.version
   }
   const pkg = await readPackageJSON(cwd)
   const pkgDep = pkg?.dependencies?.nuxt || pkg?.devDependencies?.nuxt
-  return (pkgDep && coerce(pkgDep)) || '3.0.0'
+  return (pkgDep && coerce(pkgDep)) || DEFAULT_NUXT_VERSION
 }
 
 export function getPkgVersion(cwd: string, pkg: string, options?: { via?: string[] }) {

packages/nuxt-cli/test/unit/utils/versions.spec.ts

@@ -0,0 +1,25 @@
+import { mkdtemp, rm, writeFile } from 'node:fs/promises'
+import { tmpdir } from 'node:os'
+import { join } from 'node:path'
+
+import { afterEach, beforeEach, describe, expect, it } from 'vitest'
+
+import { getNuxtVersion } from '../../../src/utils/versions'
+
+describe('getNuxtVersion', () => {
+  let tempDir: string
+
+  beforeEach(async () => {
+    tempDir = await mkdtemp(join(tmpdir(), 'nuxt-versions-test-'))
+  })
+
+  afterEach(async () => {
+    await rm(tempDir, { recursive: true, force: true })
+  })
+
+  it('should read the declared version when nuxt is not installed', async () => {
+    await writeFile(join(tempDir, 'package.json'), JSON.stringify({ devDependencies: { nuxt: '^4.2.0' } }))
+
+    expect(await getNuxtVersion(tempDir, false)).toBe('4.2.0')
+  })
+})