Skip to content

Conversation

@Colonel-Sandvich
Copy link
Contributor

πŸ”— Linked issue

resolves #613

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

nuxi info and nuxi upgrade are not able to detect what package manager is being used if Bun's new text-based lockfile bun.lock is in use.

This PR adds this file to the list of lockfiles searched for.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! we should also update in https://github.com/unjs/nypm.

@danielroe danielroe changed the title feat: add support for 'bun.lock' lockfile fix(upgrade): detect 'bun.lock' lockfile Dec 25, 2024
@pi0
Copy link
Member

pi0 commented Dec 25, 2024

Thanks for PR! Strange if it is not detected in nypm it added supported since 0.3.12 (https://github.com/unjs/nypm/pull/153/files)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@19556d3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/utils/packageManagers.ts 0.00% 15 Missing ⚠️
src/commands/upgrade.ts 0.00% 5 Missing ⚠️
src/commands/info.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #614   +/-   ##
======================================
  Coverage        ?   1.31%           
======================================
  Files           ?      44           
  Lines           ?    2898           
  Branches        ?      44           
======================================
  Hits            ?      38           
  Misses          ?    2819           
  Partials        ?      41           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe danielroe merged commit 0b61a72 into nuxt:main Dec 25, 2024
3 checks passed
@danielroe
Copy link
Member

I think issue is that nuxt/cli isn't yet using nypm to detect package manager in this file (needs to be done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: allow cli to detect new 'bun.lock' lockfile

4 participants