fix(upgrade): use nypm in upgrade and info commands #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, nypm doesn't return which lock file is in use for bun so we still have to search for that ourselves.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
======================================
Coverage ? 1.37%
======================================
Files ? 44
Lines ? 2908
Branches ? 44
======================================
Hits ? 40
Misses ? 2827
Partials ? 41 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (3)
src/commands/upgrade.ts:205
- [nitpick] The function name 'normaliseLockFile' should be renamed to 'normalizeLockFile' to follow American English spelling.
function normaliseLockFile(cwd: string, lockFiles: string | Array<string> | undefined) {
src/commands/info.ts:22
- The non-null assertion operator (!) is unnecessary here. The value of 'name' is already checked to be truthy.
const npmName = name!.split('/').splice(0, 2).join('/')
src/commands/info.ts:9
- The variables 'dependencies' and 'devDependencies' should be checked for nullish values to avoid potential issues.
getDepVersion = (name: string) => getPkg(name, cwd)?.version || dependencies[name] || devDependencies[name]
|
|
||
| if (lockFile === undefined) { | ||
| consola.error(`Unable to find any lock files in ${cwd}`) | ||
| return undefined |
There was a problem hiding this comment.
Returning 'undefined' here can lead to unintended behavior when 'undefined' is added to the 'toRemove' array. Consider handling this case more gracefully.
Suggested change
| return undefined | |
| return '' |
Further testing revealed that `utimes` throws an error if the file doesn't exist, this seemingly wasn't caught because package managers create the lockfile upon the install command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #617
❓ Type of change
📚 Description
This PR replaces old code with nymp's apis of
detectPackageManagerandaddDependency.As a bonus, we're now also supporting deno for free since nypm does