Skip to content

test: try running exec in tests with tinyexec #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2025
Merged

test: try running exec in tests with tinyexec #661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f661a
test: try running exec in tests with tinyexec
danielroe Jan 9, 2025
affa704
test: update assertion
danielroe Jan 9, 2025
4ef892e
test: skip one test
danielroe Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions test/e2e/commands.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
import type { TestFunction } from 'vitest'
import type { commands } from '../../src/commands'

import { spawnSync } from 'node:child_process'
import { fileURLToPath } from 'node:url'

import { isWindows } from 'std-env'

import { x } from 'tinyexec'
import { describe, expect, it } from 'vitest'

const fixtureDir = fileURLToPath(new URL('../../playground', import.meta.url))

// TODO: fix tests on windows
describe.skipIf(isWindows)('commands', () => {
describe('commands', () => {
const tests: Record<keyof typeof commands, 'todo' | TestFunction<object>> = {
_dev: 'todo',
add: 'todo',
Expand All @@ -32,19 +31,20 @@ describe.skipIf(isWindows)('commands', () => {
}

it('throws error if no command is provided', async () => {
const res = spawnSync('pnpm', ['nuxi'], {
cwd: fixtureDir,
const res = await x('pnpm', ['nuxi'], {
nodeOptions: { stdio: 'pipe', cwd: fixtureDir },
})
expect(res.status).toBe(isWindows ? null : 1)
expect(res.stderr.toString()).toBe('[error] No command specified.\n')
expect(res.exitCode).toBe(1)
expect(res.stderr).toBe('[error] No command specified.\n')
})

it('throws error if wrong command is provided', async () => {
const res = spawnSync('pnpm', ['nuxi', 'foo'], {
cwd: fixtureDir,
// TODO: FIXME - windows currently throws 'nuxt-foo' is not recognized as an internal or external command, operable program or batch file.
it.skipIf(isWindows)('throws error if wrong command is provided', async () => {
const res = await x('pnpm', ['nuxi', 'foo'], {
nodeOptions: { stdio: 'pipe', cwd: fixtureDir },
})
expect(res.status).toBe(isWindows ? null : 1)
expect(res.stderr.toString()).toBe('[error] Unknown command `foo`\n')
expect(res.exitCode).toBe(1)
expect(res.stderr).toBe('[error] Unknown command `foo`\n')
})

const testsToRun = Object.entries(tests).filter(([_, value]) => value !== 'todo')
Expand Down
Loading