Skip to content

feat(dev): enable fork for bun >=1.2 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat(dev): enable fork for bun >=1.2 #723

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58f6bd6
feat(dev): enable fork for bun conditionally
Saeid-Za Feb 2, 2025
933b5f2
Merge remote-tracking branch 'origin/main' into bun
danielroe Feb 13, 2025
5876687
fix: correct forking condition
danielroe Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/nuxi/src/commands/dev.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import defu from 'defu'
import { createJiti } from 'jiti'
import { getArgs as getListhenArgs, parseArgs as parseListhenArgs } from 'listhen/cli'
import { resolve } from 'pathe'
import { satisfies } from 'semver'

import { isBun, isTest } from 'std-env'
import { showVersions } from '../utils/banner'
Expand All @@ -23,7 +24,7 @@ import { loadKit } from '../utils/kit'
import { logger } from '../utils/logger'
import { cwdArgs, dotEnvArgs, envNameArgs, legacyRootDirArgs, logLevelArgs } from './_shared'

const forkSupported = !isBun && !isTest
const forkSupported = !isTest && (!isBun || isBunForkSupported())

const command = defineCommand({
meta: {
Expand Down Expand Up @@ -321,3 +322,8 @@ function _resolveListenOptions(
baseURL: nuxtOptions.app.baseURL.startsWith('./') ? nuxtOptions.app.baseURL.slice(1) : nuxtOptions.app.baseURL,
}
}

function isBunForkSupported() {
const bunVersion: string = (globalThis as any).Bun.version
return satisfies(bunVersion, '>=1.2')
}
Loading