Skip to content

Conversation

@kubicodes
Copy link
Contributor

@kubicodes kubicodes commented Feb 13, 2025

πŸ”— Linked issue

resolves #267

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

An additional flag -M was added for nuxi init .
It accepts a string of nuxt modules, as an example : nuxi init -M eslint,tailwind

@kubicodes kubicodes requested a review from danielroe as a code owner February 13, 2025 18:12
@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 13, 2025

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt-app@742
npm i https://pkg.pr.new/@nuxt/cli@742
npm i https://pkg.pr.new/nuxi@742

commit: d5684b9

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@f0efd67). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/init.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #742   +/-   ##
=======================================
  Coverage        ?   13.69%           
=======================================
  Files           ?       68           
  Lines           ?     3410           
  Branches        ?       98           
=======================================
  Hits            ?      467           
  Misses          ?     2912           
  Partials        ?       31           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe
Copy link
Member

This looks great - next time you create a PR, would you mind ticking the box to give maintainers the ability to push changes to the PR? πŸ™

@kubicodes
Copy link
Contributor Author

This looks great - next time you create a PR, would you mind ticking the box to give maintainers the ability to push changes to the PR? πŸ™

Hey, thanks for the review :) Sure, I think i accidentally removed the tick. If it's necessary I can create a new PR, just lmk πŸ™

@danielroe
Copy link
Member

No worries! I was just going to push:

const modules = !ctx.args.modules ? [] : ctx.args.modules.split(',').filter(name => !!name.trim())

@autofix-ci
Copy link
Contributor

autofix-ci bot commented Feb 13, 2025

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

Co-authored-by: Daniel Roe <daniel@roe.dev>
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❀️

@danielroe danielroe changed the title feat(init): modules flag on init feat(init): allow installing modules after clone Feb 13, 2025
@danielroe danielroe merged commit 1afc06e into nuxt:main Feb 13, 2025
6 of 10 checks passed
This was referenced Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding modules when creating the project

3 participants