Skip to content

Conversation

@pi0
Copy link
Member

@pi0 pi0 commented Jun 3, 2025

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Currently undocs based documentations fail with EMFILE: too many open files, watch on macOS because the whole node_modules and .nuxt dirs are being watched.

I think a proper long-term fix would be respecting source.exclude (like this) with separate watchers, but as a quick remedy, I made this PR.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from farnabaz June 3, 2025 19:53
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 3, 2025

Deploying content with Β Cloudflare Pages Β Cloudflare Pages

Latest commit: c5a9c95
Status:Β βœ…Β  Deploy successful!
Preview URL: https://65b3e837.content-f0q.pages.dev
Branch Preview URL: https://fix-surce-watcher-exclude.content-f0q.pages.dev

View logs

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jun 3, 2025

npm i https://pkg.pr.new/@nuxt/content@3390

commit: c5a9c95

pi0 added a commit to unjs/undocs that referenced this pull request Jun 3, 2025
@farnabaz
Copy link
Member

farnabaz commented Jun 4, 2025

What if users want to load data from a package? Hardcoding node_modules will be a breaking change.

The ignore list can be created by merging source.exclude items with source.cwd and passing it to the watcher.

@pi0
Copy link
Member Author

pi0 commented Jun 4, 2025

Yes as mentioned my primary goal was quick workaround and sharing issue. Feel free to close my PR or update it with probper exclude support. (we need to resolve globs as latest chokidar dropped support)

@farnabaz farnabaz closed this Jun 10, 2025
@pi0
Copy link
Member Author

pi0 commented Jun 10, 2025

thnx;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants