fix(devtools): run defineViteDevToolsPlugin only for client vite#977
fix(devtools): run defineViteDevToolsPlugin only for client vite#977huang-julien wants to merge 1 commit intomainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis change modifies the Vite DevTools plugin initialization to prevent server-side execution. The first file adds a Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔗 Linked issue
📚 Description
Found bug when testing out nuxt/hints#318 with Vite 8 + devtools 4.0.0-alpha.3
We need to run
connectDevToolsKitonly once otherwiser the RPC instance is overriden and won't work.