Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

refactor(bridge): align bridge with vite and inline systemjs polyfill in entry#4005

Merged
pi0 merged 3 commits intomainfrom
fix/bridge-vite-align
Apr 1, 2022
Merged

refactor(bridge): align bridge with vite and inline systemjs polyfill in entry#4005
pi0 merged 3 commits intomainfrom
fix/bridge-vite-align

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves nuxt/bridge#129

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR:

  1. makes bridge + vite-builder more closely aligned, including porting support for dynamic base paths to bridge vite, including using untyped to give us just the vite default options
  2. inlines systemjs polyfill for now (otherwise it was susceptible to a race condition and possibly not being loaded - note that this is a temporary fix and we will remove legacy support in bridge: Serve modern format with bridge and vite bridge#15

A lingering issue is that Bridge does not respect static URLs in terms of custom baseURL or cdnURL - this can be deferred to another PR.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working bridge ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf labels Mar 31, 2022
@danielroe danielroe requested a review from pi0 March 31, 2022 21:01
@danielroe danielroe self-assigned this Mar 31, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Mar 31, 2022

Deploy Preview for nuxt3-docs canceled.

Name Link
🔨 Latest commit ffcd011
🔍 Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/6246bb9197ac9c00082267bb

Comment thread packages/bridge/src/vite/vite.ts Outdated
Comment thread packages/bridge/src/vite/vite.ts Outdated
Comment thread packages/vite/src/plugins/dynamic-base.ts
@pi0 pi0 merged commit ade3378 into main Apr 1, 2022
@pi0 pi0 deleted the fix/bridge-vite-align branch April 1, 2022 13:22
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3.x bridge bug Something isn't working ❗ p4-important Priority 4: bugs that violate documented behavior, or significantly impact perf

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxi generate: ReferenceError: System is not defined

2 participants