feat: allow switching between max-width and min-width#2127
feat: allow switching between max-width and min-width#2127DamianGlowala wants to merge 4 commits intomainfrom
max-width and min-width#2127Conversation
commit: |
Deploying nuxt-image with
|
| Latest commit: |
23744f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c98105b6.nuxt-image.pages.dev |
| Branch Preview URL: | https://feat-responsive-breakpoints.nuxt-image.pages.dev |
📝 WalkthroughWalkthroughAdds a new responsiveBreakpoints option (values: 'max-width' | 'min-width') to the Nuxt Image module and types, with default 'max-width' and a per-component prop. Passes the option through NuxtImg/NuxtPicture to the runtime sizing logic, updates getSizes/finaliseSizeVariants to generate media queries according to the chosen strategy, and exposes the prop in BaseImageProps. Documentation pages were updated with configuration and prop examples. Tests and snapshots were updated/duplicated to cover both breakpoint modes. Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/nuxt/picture.test.ts`:
- Line 359: Add the missing trailing comma after the object property
responsiveBreakpoints: 'min-width' in the test case so the object literal
conforms to the linter rules; locate the object containing the
responsiveBreakpoints property in picture.test.ts (search for
"responsiveBreakpoints" or the test that configures picture component) and
append a comma after 'min-width'.
- Around line 330-338: The test attempts to delete a non-configurable property
nuxtApp.$img and also includes a redundant afterEach; remove the delete
nuxtApp.$img line from the beforeEach and delete the entire afterEach block,
leaving only deletion of nuxtApp._img in beforeEach so useImage() can lazily
recreate $img from _img without causing a TypeError and to avoid duplicate
teardown.
There was a problem hiding this comment.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@test/nuxt/picture.test.ts`:
- Around line 330-338: Remove the unsafe deletion of nuxtApp.$img and the
redundant afterEach block: only delete nuxtApp._img in the beforeEach because
useImage() will lazily recreate $img from _img; remove the entire afterEach(...)
that duplicates the beforeEach cleanup and also remove the now-unused afterEach
import at the top of the test file; leave any deletion of nuxtApp.$img out to
avoid TypeError for the non-configurable getter created by
nuxtApp.provide('img', ...).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
========================================
+ Coverage 6.83% 6.86% +0.02%
========================================
Files 80 80
Lines 3729 3742 +13
Branches 142 142
========================================
+ Hits 255 257 +2
- Misses 3424 3435 +11
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔗 Linked issue
resolves #1211
📚 Description
Adds
responsiveBreakpointsoption to choose betweenmax-width(default) andmin-widthfor generatingsizesprop. This option can be configured both for a module and for a given component.Naming can be changed if anyone suggests a better suited alternative.