Skip to content

ci: add merge group config#2137

Merged
danielroe merged 1 commit intomainfrom
ci/merge-group
Feb 25, 2026
Merged

ci: add merge group config#2137
danielroe merged 1 commit intomainfrom
ci/merge-group

Conversation

@danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 25, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2137

commit: b74fc11

@cloudflare-workers-and-pages
Copy link

Deploying nuxt-image with  Cloudflare Pages  Cloudflare Pages

Latest commit: b74fc11
Status: ✅  Deploy successful!
Preview URL: https://101ab0d7.nuxt-image.pages.dev
Branch Preview URL: https://ci-merge-group.nuxt-image.pages.dev

View logs

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

📝 Walkthrough

Walkthrough

The changes modify the GitHub Actions CI workflow to implement path-based job filtering. A new changes job is introduced using the dorny/paths-filter action to detect modifications in source directories, test folders, and configuration files. The existing lint and ci jobs are made conditional on the detection of source changes through a dependency relationship. A new ci-ok aggregator job is added that always runs and validates the success status of the preceding jobs, failing if any dependent job fails or is cancelled. Additionally, the workflow now triggers on the merge_group event.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description contains only the PR template with no actual content describing the changes, rationale, or implementation details. Provide a detailed description explaining why the merge group config is needed, what problem it solves, and the implementation approach.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ci: add merge group config' directly aligns with the main change: adding merge_group trigger and related CI workflow updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/merge-group

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

115-136: Follow-up: make ci-ok the required status check in branch protection.

Since lint/ci can now be intentionally skipped, require ci-ok (instead of requiring lint/ci directly) to avoid merge queue deadlocks on no-op changes.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 115 - 136, The branch protection needs
to require the aggregated job "ci-ok" instead of the individual "lint" and "ci"
jobs to avoid deadlocks when those jobs are intentionally skipped; update your
repository's branch protection rules to mark "ci-ok" as the required status
check (rather than "lint" and "ci"), ensuring the workflow job named ci-ok
(which depends on changes, lint, ci) is the gatekeeper for merges.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 115-136: The branch protection needs to require the aggregated job
"ci-ok" instead of the individual "lint" and "ci" jobs to avoid deadlocks when
those jobs are intentionally skipped; update your repository's branch protection
rules to mark "ci-ok" as the required status check (rather than "lint" and
"ci"), ensuring the workflow job named ci-ok (which depends on changes, lint,
ci) is the gatekeeper for merges.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6b5bd1 and b74fc11.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 6.83%. Comparing base (d6b5bd1) to head (b74fc11).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2137   +/-   ##
=====================================
  Coverage   6.83%   6.83%           
=====================================
  Files         80      80           
  Lines       3732    3732           
  Branches     142     142           
=====================================
  Hits         255     255           
  Misses      3427    3427           
  Partials      50      50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe added this pull request to the merge queue Feb 25, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 25, 2026
Merged via the queue into main with commit c273192 Feb 25, 2026
11 checks passed
@danielroe danielroe deleted the ci/merge-group branch February 25, 2026 09:08
@github-actions github-actions bot mentioned this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants