refactor: unify cards and cards list #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
clemcode
reviewed
Jan 4, 2023
components/content/CardItem.vue
Outdated
| >, | ||
| default: () => {} | ||
| }, | ||
| backgroundImg: { |
Contributor
There was a problem hiding this comment.
backgroundImage could be more explicit and cohesive with the Image prop
components/content/CardItem.vue
Outdated
Comment on lines
89
to
94
| { | ||
| path: String, | ||
| width: any, | ||
| height: any, | ||
| format: String | ||
| } |
Contributor
There was a problem hiding this comment.
This can be an interface to reuse below
interface Image {
path: string,
width: any,
height: any,
format: string
}
danielroe
pushed a commit
that referenced
this pull request
Oct 18, 2023
* refactor: unify cards and cards list * fix(jobsListItem): light color on remote tag * refactor: use image interface for image props Co-authored-by: Clément Ollivier <clement.o2p@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1123