fix(vite): ensure leading slash in /@fs URLs for Windows#34810
Conversation
|
|
@nuxt/kit
@nuxt/nitro-server
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThe change updates CSS path construction in the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merging this PR will improve performance by 12.19%
Performance Changes
Comparing Footnotes
|
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
🔗 Linked issue
Fixes: #34766
📚 Description
Because of the fix (from me.... 😒) #34303....
Instead of generating a valid path in
getManifestsuch as:/@fs/D:/project/.../style.cssNuxt may emit:
/@fsD:/project/.../style.cssThat malformed URL returns 404 in development. The fix is simple check if path isn't starting with "/", add one slash.