Skip to content

fix(nuxt): respect factory fetch/baseURL options in server useFetch#35003

Merged
danielroe merged 5 commits into
4.xfrom
fix/ssr-custom-fetch-baseurl
May 8, 2026
Merged

fix(nuxt): respect factory fetch/baseURL options in server useFetch#35003
danielroe merged 5 commits into
4.xfrom
fix/ssr-custom-fetch-baseurl

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #34996

📚 Description

previously, we only checked opts in this branch, not the merged fetchOptions

@danielroe danielroe requested a review from cernymatej May 7, 2026 20:31
@danielroe danielroe self-assigned this May 7, 2026
@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added 4.x 🐛 bug Something isn't working as expected labels May 7, 2026
@danielroe danielroe changed the title fix(nuxt): respect factory $fetch/baseURL in server useFetch fix(nuxt): respect factory fetch/baseURL options in server useFetch May 7, 2026
Copy link
Copy Markdown
Member

@cernymatej cernymatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the lock file change made by autofix is probably not desired?

@danielroe danielroe force-pushed the fix/ssr-custom-fetch-baseurl branch 2 times, most recently from b9c4729 to e142bec Compare May 7, 2026 20:52
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@35003

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@35003

nuxt

npm i https://pkg.pr.new/nuxt@35003

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@35003

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@35003

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@35003

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@35003

commit: eea83e0

@danielroe danielroe force-pushed the fix/ssr-custom-fetch-baseurl branch from 445d12d to f824112 Compare May 7, 2026 21:04
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 7, 2026

Merging this PR will not alter performance

✅ 20 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing fix/ssr-custom-fetch-baseurl (eea83e0) with 4.x (816c254)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danielroe danielroe merged commit d1f7c8a into 4.x May 8, 2026
28 checks passed
@danielroe danielroe deleted the fix/ssr-custom-fetch-baseurl branch May 8, 2026 07:45
This was referenced May 8, 2026
davidstackio pushed a commit to davidstackio/nuxt that referenced this pull request May 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x 🐛 bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants