Skip to content

fix(vite): only consider CSS inlined when styles are actually emitted#35006

Merged
danielroe merged 1 commit into
4.xfrom
fix/inline-styles-4.x
May 7, 2026
Merged

fix(vite): only consider CSS inlined when styles are actually emitted#35006
danielroe merged 1 commit into
4.xfrom
fix/inline-styles-4.x

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

follow-up to #34950

the dedupe added there populated inlinedCSSModuleIds during the server transform for any module whose CSS imports could be resolved - including modules whose styles never actually reach the SSR response (e.g. ambient CSS imports in .ts files like FunctionalComponent.ts).

their chunk's bundled CSS link was then wrongly dropped.

(this seems to have surfaced due to a rolldown/vite change as this originally passed in CI)

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added 4.x 🐛 bug Something isn't working as expected labels May 7, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 7, 2026

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@35006

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@35006

nuxt

npm i https://pkg.pr.new/nuxt@35006

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@35006

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@35006

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@35006

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@35006

commit: 3df59ba

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 7, 2026

Merging this PR will not alter performance

✅ 20 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing fix/inline-styles-4.x (3df59ba) with 4.x (cd404a1)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danielroe danielroe merged commit bfe8964 into 4.x May 7, 2026
47 of 49 checks passed
@danielroe danielroe deleted the fix/inline-styles-4.x branch May 7, 2026 22:20
This was referenced May 7, 2026
@github-actions github-actions Bot mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x 🐛 bug Something isn't working as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant