Skip to content

perf(kit): cache layer roots and short-circuit isIgnored relative#35015

Merged
danielroe merged 1 commit into
mainfrom
perf/layer-path-cache
May 9, 2026
Merged

perf(kit): cache layer roots and short-circuit isIgnored relative#35015
danielroe merged 1 commit into
mainfrom
perf/layer-path-cache

Conversation

@danielroe
Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

spotted this while investigating #27106.

this avoids rebuilding layer paths and re-invoking pathe.relative (which resolves + splits + copies).

isIgnored is called so many times, so this really adds up.

@bolt-new-by-stackblitz
Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added 5.x ⚡ performance Performance degradation or optimization opportunity labels May 9, 2026
@coderabbitai

This comment has been minimized.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 9, 2026

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@35015

@nuxt/nitro-server

npm i https://pkg.pr.new/@nuxt/nitro-server@35015

nuxt

npm i https://pkg.pr.new/nuxt@35015

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@35015

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@35015

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@35015

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@35015

commit: 6f25131

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 9, 2026

Merging this PR will improve performance by 10.07%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 19 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
initial dev server build in the basic test fixture 906.6 ms 823.7 ms +10.07%

Comparing perf/layer-path-cache (6f25131) with main (d4eaa42)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@danielroe danielroe merged commit 05ea7dd into main May 9, 2026
48 of 50 checks passed
@danielroe danielroe deleted the perf/layer-path-cache branch May 9, 2026 18:34
@github-actions github-actions Bot mentioned this pull request May 9, 2026
4 tasks
@github-actions github-actions Bot mentioned this pull request May 8, 2026
@github-actions github-actions Bot mentioned this pull request May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.x ⚡ performance Performance degradation or optimization opportunity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant