fix(nitro): point cache driver at .mjs runtime output#35263
Conversation
@nuxt/kit
@nuxt/nitro-server
nuxt
@nuxt/rspack-builder
@nuxt/schema
@nuxt/vite-builder
@nuxt/webpack-builder
commit: |
| await fsp.rm(cacheDir, { recursive: true, force: true }).catch(() => {}) | ||
| nitro.options._config.storage = defu(nitro.options._config.storage, { | ||
| 'internal:nuxt:prerender': { | ||
| // TODO: resolve upstream where file URLs are not being resolved/inlined correctly |
There was a problem hiding this comment.
I'm concerned about this TODO here but I couldn't get a full understanding whether this really needed to be fixed at nitro level. I imagine nitro expects a resolved path? Maybe without the extension? @pi0 do you know?
There was a problem hiding this comment.
if nitro expects a resolved path, should we drop the TODO too?
There was a problem hiding this comment.
it was an issue that only occurred on windows IIRC - we'd need to test it on windows to see if this issue still happens
There was a problem hiding this comment.
the pain, do we have anybody on the team using windows that can test it?
This comment has been minimized.
This comment has been minimized.
posva
changed the title
Merging this PR will degrade performance by 18.5%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | writeTypes in the basic-types fixture |
48.7 ms | 59.7 ms | -18.5% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing fix/nitro-server-prerender-cache-driver (8a4ec31) with main (5a126b1)
Footnotes
-
3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
2 participants
Fix #35247