Skip to content

feat(server): configurable app option#5605

Closed
galvez wants to merge 3 commits into
devfrom
feat/server-app-option
Closed

feat(server): configurable app option#5605
galvez wants to merge 3 commits into
devfrom
feat/server-app-option

Conversation

@galvez
Copy link
Copy Markdown
Contributor

@galvez galvez commented Apr 26, 2019

@galvez galvez changed the title Feat/server app option feat(server): configurable app option Apr 26, 2019
@clarkdo
Copy link
Copy Markdown
Member

clarkdo commented Apr 26, 2019

I think we need type definition for app to constraint its API like use, req and res or at least doc/comment to describe it, so that user won't make any mistake to use a customized server middleware.

And actually connect is a very pure middleware, it won't have much influence in performance except that it doesn't support async handler (which can be trickily implemented by calling next after await/in promise).
As customized server middleware may not be as efficiency as connect, maybe we should consider if it's necessary to open this door as it's similar to programmatical Nuxt usage.

If the customized server middleware is better than connect, we can just replace it with new one since app is very common (a server layer) and won't include special logic.

@galvez
Copy link
Copy Markdown
Contributor Author

galvez commented Apr 26, 2019

@clarkdo as per discussion in the #core channel, I'm withdrawing this in favor of pushing to a full replacement of connect soon.

@galvez galvez closed this Apr 26, 2019
@pi0 pi0 deleted the feat/server-app-option branch April 26, 2019 09:51
@douira
Copy link
Copy Markdown

douira commented Aug 15, 2019

What does "soon" mean? When is this replacement of connect coming? Is it going to have to wait until nuxt 3?

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants