Skip to content

fix(types): add googleSignIn to ScriptRegistry#627

Merged
harlan-zw merged 1 commit intonuxt:mainfrom
zizzfizzix:google-sign-in-registry-typing
Mar 5, 2026
Merged

fix(types): add googleSignIn to ScriptRegistry#627
harlan-zw merged 1 commit intonuxt:mainfrom
zizzfizzix:google-sign-in-registry-typing

Conversation

@zizzfizzix
Copy link
Copy Markdown
Contributor

🔗 Linked issue

N/A

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

GoogleSignIn was missing from the ScriptRegistry interface in runtime/types.ts despite having a full registry implementation.

GoogleSignIn was missing from the ScriptRegistry interface in runtime/types.ts
despite having a full registry implementation.
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 5, 2026

@zizzfizzix is attempting to deploy a commit to the Nuxt Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7158c783-179d-4ba8-a4c7-3830b6c800e3

📥 Commits

Reviewing files that changed from the base of the PR and between 4682126 and 5aee327.

📒 Files selected for processing (1)
  • src/runtime/types.ts

📝 Walkthrough

Walkthrough

A new optional field googleSignIn of type GoogleSignInInput was added to the ScriptRegistry interface in src/runtime/types.ts. This extends the interface to support Google Sign-In script configuration while maintaining backward compatibility through the optional field modifier.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: adding the googleSignIn field to the ScriptRegistry interface.
Description check ✅ Passed The description includes the required type of change (bug fix) and explains the problem being solved, though the 'Description' section is brief.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 5, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/scripts@627

commit: 087c578

@harlan-zw
Copy link
Copy Markdown
Collaborator

Your on fire 🔥 thanks

@harlan-zw harlan-zw merged commit be31ec1 into nuxt:main Mar 5, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants