Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/runtime/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export function useRegistryScript<T extends Record<string | symbol, any>, O = Em
}

const scriptInput = defu(finalScriptInput, userOptions.scriptInput, { key: registryKey }) as any as UseScriptInput
const scriptOptions = Object.assign(userOptions?.scriptOptions || {}, options.scriptOptions || {})
const scriptOptions = { ...userOptions?.scriptOptions, ...options.scriptOptions }
if (import.meta.dev) {
// Capture where the component was loaded from
const error = new Error('Stack trace for component location')
Expand Down
15 changes: 15 additions & 0 deletions test/unit/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,21 @@ vi.mock('#nuxt-scripts-validator', () => ({
parse: vi.fn(),
}))

describe('useRegistryScript scriptOptions', () => {
it('should not mutate user-provided scriptOptions', () => {
const mockOptionsFunction = vi.fn((_opts, _ctx) => ({
scriptInput: { src: 'https://example.com/script.js' },
scriptOptions: { use: () => ({ test: true }) },
}))

const userScriptOptions = { trigger: 'onNuxtReady' as const }
const userOptions = { scriptOptions: userScriptOptions }
useRegistryScript('test', mockOptionsFunction, userOptions)

expect(userScriptOptions).not.toHaveProperty('use')
})
})

describe('useRegistryScript query param merging', () => {
it('should merge query params when user provides custom src', () => {
const mockOptionsFunction = vi.fn((_opts, _ctx) => ({
Expand Down
Loading