Skip to content

fix(youtube-player): a11y keyboard-accessible #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 2 commits into from
May 27, 2026
Merged

fix(youtube-player): a11y keyboard-accessible #798

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c8bdc0
fix(youtube-player): make placeholder keyboard-accessible
harlan-zw May 27, 2026
d752b44
Merge remote-tracking branch 'origin/main' into worktree-agent-a27f76…
harlan-zw May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions packages/script/src/runtime/components/ScriptYouTubePlayer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,16 +197,41 @@ defineExpose({
player,
})

// Keyboard accessibility: dispatch the configured trigger event on Enter/Space
// so users navigating via keyboard can activate the placeholder (fixes #797).
const keyboardTriggerable = computed(() => {
if (isTriggered.value)
return false
const triggers = Array.isArray(props.trigger) ? props.trigger : [props.trigger]
return triggers.some(t => typeof t === 'string' && !['immediate', 'onNuxtReady', 'visibility', 'visible'].includes(t))
})

function onPlaceholderKeydown(e: KeyboardEvent) {
if (e.key !== 'Enter' && e.key !== ' ')
return
e.preventDefault()
if (!rootEl.value)
return
const triggers = (Array.isArray(props.trigger) ? props.trigger : [props.trigger]).filter(Boolean) as string[]
for (const t of triggers) {
if (['immediate', 'onNuxtReady', 'visibility', 'visible'].includes(t))
continue
rootEl.value.dispatchEvent(new Event(t, { bubbles: false }))
}
}

const rootAttrs = computed(() => {
const interactive = keyboardTriggerable.value
return defu(props.rootAttrs, {
'aria-busy': status.value === 'loading',
'aria-label': status.value === 'awaitingLoad'
? 'YouTube Player - Placeholder'
? (interactive ? 'Play video' : 'YouTube Player - Placeholder')
: status.value === 'loading'
? 'YouTube Player - Loading'
: 'YouTube Player - Loaded',
'aria-live': 'polite',
'role': 'application',
'role': interactive ? 'button' : 'application',
'tabindex': interactive ? 0 : undefined,
'style': {
cursor: 'pointer',
position: 'relative',
Expand Down Expand Up @@ -265,7 +290,7 @@ const placeholderAttrs = computed(() => {
</script>

<template>
<div ref="rootEl" v-bind="rootAttrs">
<div ref="rootEl" v-bind="rootAttrs" @keydown="keyboardTriggerable ? onPlaceholderKeydown($event) : undefined">
<div ref="youtubeEl" style="width: 100%; height: 100%; position: absolute; top: 0; left: 0;" />
<slot v-if="!ready" :placeholder="placeholder" name="placeholder">
<img v-bind="placeholderAttrs">
Expand Down
Loading