Skip to content

chore: switch unit test target to dir and move type unit tests to test:types#1618

Merged
danielroe merged 1 commit intonuxt:mainfrom
yamachi4416:chore-unit-test-specify-dir
Mar 15, 2026
Merged

chore: switch unit test target to dir and move type unit tests to test:types#1618
danielroe merged 1 commit intonuxt:mainfrom
yamachi4416:chore-unit-test-specify-dir

Conversation

@yamachi4416
Copy link
Collaborator

@yamachi4416 yamachi4416 commented Mar 15, 2026

🔗 Linked issue

📚 Description

  • test:unit was running tests outside ./test/unit, so it was changed to use --dir
  • test:unit:types felt more natural under test:types, so it was moved to test:types

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 15, 2026

Open in StackBlitz

npm i https://pkg.pr.new/nuxt/test-utils/@nuxt/test-utils@1618
npm i https://pkg.pr.new/nuxt/test-utils/vitest-environment-nuxt@1618

commit: 8b691a4

@yamachi4416 yamachi4416 marked this pull request as ready for review March 15, 2026 04:29
@yamachi4416 yamachi4416 requested a review from danielroe as a code owner March 15, 2026 04:29
@coderabbitai
Copy link

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f1058cf8-8a12-4a27-8115-3e0071ae731c

📥 Commits

Reviewing files that changed from the base of the PR and between a40ddf1 and 406e94f.

📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The package.json test scripts were reorganized: the main test script now runs test:types, test:unit, and test:examples. test:types now performs both vue-tsc (noEmit) and Vitest type-checking for ./test/types in one step. test:unit runs Vitest for ./test/unit. The separate test:unit:types entry was removed and its type-checking responsibilities moved into test:types. No exported API changes were made.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: switching unit test target to use --dir and consolidating type unit tests into test:types.
Description check ✅ Passed The description clearly relates to the changeset by explaining why test:unit was changed to use --dir and why test:unit:types was moved to test:types.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes with custom instructions.

Set the reviews.auto_title_instructions setting to generate a title for your PR based on the changes in the PR with custom instructions.

@yamachi4416 yamachi4416 force-pushed the chore-unit-test-specify-dir branch from a40ddf1 to 406e94f Compare March 15, 2026 10:03
@danielroe danielroe merged commit d75f5f2 into nuxt:main Mar 15, 2026
7 checks passed
@github-actions github-actions bot mentioned this pull request Mar 15, 2026
@yamachi4416 yamachi4416 deleted the chore-unit-test-specify-dir branch March 15, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants