Skip to content

fix(vitest-environment): respect custom url in setup#957

Merged
danielroe merged 1 commit into
nuxt:mainfrom
harunari0928:bugfix
Oct 3, 2024
Merged

fix(vitest-environment): respect custom url in setup#957
danielroe merged 1 commit into
nuxt:mainfrom
harunari0928:bugfix

Conversation

@harunari0928

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Removed the hardcoded window URL. Now it references an environment option for better configurability.

@harunari0928 harunari0928 marked this pull request as ready for review September 28, 2024 02:37

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️

@danielroe danielroe changed the title fix: eliminate hardcoded window URL ix(vitest-environment): respect custom url in setup Sep 28, 2024
@danielroe danielroe changed the title ix(vitest-environment): respect custom url in setup fix(vitest-environment): respect custom url in setup Sep 28, 2024
@danielroe danielroe merged commit 44f47d9 into nuxt:main Oct 3, 2024
@github-actions github-actions Bot mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants